Re: [PATCH] regulator: pfuze100-regulator: Fix some checkpatch complaints

[Fabio Estevam]

On Wed, Jan 15, 2014 at 1:02 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2014-01-15 at 00:52 -0200, Fabio Estevam wrote:
>> Fix the following checkpatch error and warning:
>
> While you're at it:
>
>> diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
> []
>> @@ -309,14 +309,17 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip)
> []
>> +     case 0x8:
>> +             dev_info(pfuze_chip->dev, "Assuming misprogrammed ID=0x8");
>
> missing "\n" terminating newline and
> missing break (or fallthrough comment)
>
>> +     case 0x0:
>> +             break;
>> +     default:
>> +             dev_warn(pfuze_chip->dev, "Illegal ID: %x\n", value);
>
> invalid vs illegal

Thanks, Joe.

Will address your suggestions through a different patch.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/