Re: [PATCH 2/2] sys, seccomp: add PR_SECCOMP_EXT andSECCOMP_EXT_ACT_TSYNC

[Oleg Nesterov]

On 01/15, Oleg Nesterov wrote:
>
> I think the
> locking is seriously broken in this series.

And imho seccomp_sync_threads() should fail "safely".

IOW, I think it should do while_each_thread() twice. The first
iteration should just check SECCOMP_MODE_FILTER/is_ancestor()
and fail if necessary. The 2nd one should change other threads.

Btw, it seems that is_ancestor() doesn't need the NULL check,
it is not called if SECCOMP_MODE_DISABLED ?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/