Re: [PATCH tip/core/timers 4/4] timers: Reduce future__run_timers() latency for first add to empty list

From: Oleg Nesterov
Date: Wed Jan 15 2014 - 12:24:46 EST


On 01/14, Paul E. McKenney wrote:
>
> @@ -749,6 +749,7 @@ __mod_timer(struct timer_list *timer, unsigned long expires,
>
> base = lock_timer_base(timer, &flags);
>
> + (void)catchup_timer_jiffies(base);

Agreed, but perhaps it would be better to do this before
all_timers++ in internal_add_timer() ?

This is funny, but I already have the same change for ->next_timer,
if we add this optimization perhaps that trivial patch makes sense
too.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/