Re: [PATCH 08/17] tools lib traceevent: Unregister handler whenfunction plugin unloaded

[Steven Rostedt]

On Wed, 15 Jan 2014 10:45:31 +0900
Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> The function handler should be unregistered when the plugin unloaded
> otherwise it'll try to access invalid memory.
> 
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


> ---
>  tools/lib/traceevent/plugin_function.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/lib/traceevent/plugin_function.c b/tools/lib/traceevent/plugin_function.c
> index 39461485f9a7..80ba4ff1fe84 100644
> --- a/tools/lib/traceevent/plugin_function.c
> +++ b/tools/lib/traceevent/plugin_function.c
> @@ -148,6 +148,9 @@ void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
>  {
>  	int i, x;
>  
> +	pevent_unregister_event_handler(pevent, -1, "ftrace", "function",
> +					function_handler, NULL);
> +
>  	for (i = 0; i <= cpus; i++) {
>  		for (x = 0; x < fstack[i].size && fstack[i].stack[x]; x++)
>  			free(fstack[i].stack[x]);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/