Re: [tip:core/urgent] sched_clock: Disable seqlock lockdep usage insched_clock()

From: Ingo Molnar
Date: Wed Jan 15 2014 - 01:38:46 EST



* John Stultz <john.stultz@xxxxxxxxxx> wrote:

> On 01/12/2014 10:42 AM, tip-bot for John Stultz wrote:
> > Commit-ID: 7a06c41cbec33c6dbe7eec575c61986122617408
> > Gitweb: http://git.kernel.org/tip/7a06c41cbec33c6dbe7eec575c61986122617408
> > Author: John Stultz <john.stultz@xxxxxxxxxx>
> > AuthorDate: Thu, 2 Jan 2014 15:11:14 -0800
> > Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> > CommitDate: Sun, 12 Jan 2014 10:14:00 +0100
> >
> > sched_clock: Disable seqlock lockdep usage in sched_clock()
> >
> > Unfortunately the seqlock lockdep enablement can't be used
> > in sched_clock(), since the lockdep infrastructure eventually
> > calls into sched_clock(), which causes a deadlock.
> >
> > Thus, this patch changes all generic sched_clock() usage
> > to use the raw_* methods.
> >
> > Acked-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > Reported-by: Krzysztof HaÅasa <khalasa@xxxxxxx>
> > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> > Cc: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Cc: Willy Tarreau <w@xxxxxx>
> > Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Link: http://lkml.kernel.org/r/1388704274-5278-2-git-send-email-john.stultz@xxxxxxxxxx
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>
> Hey Ingo,
> Just wanted to follow up here, since I've still not seen this (and
> the raw_ renaming patch) submitted to Linus. These address a lockup that
> triggers on ARM systems if lockdep is enabled and it would be good to
> get it in before 3.13 is out.

It's in tip:core/urgent, i.e. lined up for v3.13, I plan to send it to
Linus later today.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/