Re: [RFC PATCH] sched: find the latest idle cpu

From: Alex Shi
Date: Tue Jan 14 2014 - 23:53:43 EST


On 01/15/2014 12:48 PM, Alex Shi wrote:
> On 01/15/2014 12:31 PM, Michael wang wrote:
>> Hi, Alex
>>
>> On 01/15/2014 12:07 PM, Alex Shi wrote:
>> [snip] }
>>> +#ifdef CONFIG_NO_HZ_COMMON
>>> + /*
>>> + * Coarsely to get the latest idle cpu for shorter latency and
>>> + * possible power benefit.
>>> + */
>>> + if (!min_load) {
>
> here should be !load.
>>> + struct tick_sched *ts = &per_cpu(tick_cpu_sched, i);
>>> +
>>> + s64 latest_wake = 0;
>>
>> I guess we missed some code for latest_wake here?
>
> Yes, thanks for reminder!
>
> so updated patch:
>

ops, still incorrect. re-updated:

===