Re: [PATCH 0/3] KGDB/KDB/UV: Fixups for UV to KGDB interface

From: Ingo Molnar
Date: Tue Jan 14 2014 - 11:28:54 EST



* Mike Travis <travis@xxxxxxx> wrote:

>
> v2: Update patch 2/3 to include which problems fixed. Other minor
> changes detailed in the patches.
>
> * 1/3: Change the fix for 'KDB not defined' build problem by changing
> the kgdb_nmicallin() interface to include the KDB specific reason code.
> This removes the dependency on KDB in the debug core. It also requires
> a change to the kgdb call in from UV NMI handler to avoid a compile
> error.
>
> * 2/3: Fix problems found by the kbuild test robot tip-bot:
> Make uv_register_nmi_notifier() and uv_handle_nmi_ping() static to
> address sparse warnings. Fix problem where uv_nmi_kexec_failed is
> unused when CONFIG_KEXEC is not defined.
>
> * 3/3: Fix UV call into kgdb to depend only on whether KGDB is defined
> and not both KGDB and KDB. This allows the power nmi command to
> use the gdb remote connection if enabled. Note new action of 'kgdb'
> needs to be set as well to indicate user wants the kernel to wait for
> gdb to be connected. If it's set to 'kdb' then an error message is
> displayed if KDB is not configured.
>
> Also note that if both KGDB and KDB are enabled, then the action
> of 'kgdb' or 'kdb' has no affect on which is used. See the KGDB
> documentation for further information.

So unless Jason objects I plan to merge these bits in a day or two,
for a v3.14 merge (if they pass all review and testing).

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/