Re: [PATCH 2/3] power: clock_ops.c: check return of clk_enable()in pm_clk_resume()

[Ben Dooks]

On 13/01/14 19:55, Rafael J. Wysocki wrote:
> On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:

> > @@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
> >
> >   	list_for_each_entry(ce, &psd->clock_list, node) {
> >   		if (ce->status < PCE_STATUS_ERROR) {
> > -			clk_enable(ce->clk);
> > -			ce->status = PCE_STATUS_ENABLED;
> > +			ret = clk_enable(ce->clk);
> > +			if (ret == 0)
>
> Can you please use if (!ret) here?
>
> And analogously in patch [3/3]?

I will fix and re-send today, thanks.


--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/