Re: [PATCH 11/12] x86 Kconfig: create x86/Kconfig.virt

From: Dave Hansen
Date: Mon Jan 13 2014 - 18:02:24 EST


On 01/13/2014 02:46 PM, Paolo Bonzini wrote:
> Il 13/01/2014 20:22, Dave Hansen ha scritto:
>> diff -puN arch/x86/Kconfig~x86-Kconfig-move-paravirt-under-virtualization arch/x86/Kconfig
>> --- linux.git/arch/x86/Kconfig~x86-Kconfig-move-paravirt-under-virtualization 2014-01-13 11:11:36.617255854 -0800
>> +++ linux.git-davehans/arch/x86/Kconfig 2014-01-13 11:11:36.620255990 -0800
>
> These diff headers are unreadable...

Man, and I thought I was pedantic about about those kinds of things. I
guess git has spoiled everyone. :)

>> @@ -2416,6 +2416,6 @@ source "security/Kconfig"
>>
>> source "crypto/Kconfig"
>>
>> -source "arch/x86/kvm/Kconfig"
>> +source "arch/x86/Kconfig.virt"
>>
>> source "lib/Kconfig"
>> diff -puN /dev/null arch/x86/Kconfig.virt
>> --- /dev/null 2013-11-27 17:20:18.337162396 -0800
>> +++ linux.git-davehans/arch/x86/Kconfig.virt 2014-01-13 11:11:36.621256035 -0800
>> @@ -0,0 +1,18 @@
>> +
>> +menuconfig VIRTUALIZATION
>> + bool "Virtualization"
>
> Please rename this to "Hypervisor support" or "Virtual guest support" to
> avoid confusion with KVM. Note there is a reference to
> CONFIG_VIRTUALIZATION in configs/kvm_guest.config.

I'm not sure I'm following. When this gets done, we have a menu that says:

> --- Virtualization
> <*> Kernel-based Virtual Machine (KVM) support
> <*> KVM for Intel processors support
> <*> KVM for AMD processors support
> [*] Audit KVM MMU
> [*] KVM legacy PCI device assignment support
> < > Host kernel accelerator for virtio net
> [*] Linux guest support --->

So this new menu grouping includes both KVM, Xen, and lguest. It
includes both the host-side and guest-side support. Are you suggesting
that we separate out host and guest somehow?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/