Re: [PATCH net-next] qlcnic: Convert vmalloc/memset to kcalloc

From: David Miller
Date: Mon Jan 13 2014 - 14:17:56 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Wed, 08 Jan 2014 22:42:25 -0800

> vmalloc is a limited resource. Don't use it unnecessarily.
>
> It seems this allocation should work with kcalloc.
>
> Remove unnecessary memset(,0,) of buf as it's completely
> overwritten as the previously only unset field in
> struct qlcnic_pci_func_cfg is now set to 0.
>
> Use kfree instead of vfree.
> Use ETH_ALEN instead of 6.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/