Re: [PATCH v5] video: add OpenCores VGA/LCD framebuffer driver

[Tomi Valkeinen]

On 2014-01-13 12:20, Stefan Kristiansson wrote:

> The VGA/LCD in the subject comes from the name of the core,
> the core itself presents a "vga-type" interface, but it can basically
> be hooked up to any type of display (with a bit of glue-logic in some cases).
> 
> That said - the reason why I went for the mode_options solution in the
> first place, is that when I initially wrote this driver
> (>2 years ago, time flies...) the display-timing device-tree bindings weren't
> invented yet, so it seemed like the most viable option without coming up
> with custom device-tree bindings.
> 
> It's completely possible that this design choice should be revised now,
> and I wouldn't mind converting this driver to make use of the display-timing
> dt properties if you think that's a good idea?

I don't have a strong opinion on this. It looks to me that even if the
current driver is merged, it would be easy to add device tree
display-timing later, and still keep full backward compatibility.

Then again, you already have DT support in the driver, and if it's clear
that the DT based videomode selection is better, then I'd just go
straight to that one without intermediate steps.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature