RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writingto the platform data
From: Li.Xiubo@xxxxxxxxxxxxx
Date: Mon Jan 13 2014 - 04:10:22 EST
Hi Mark, Jean-Francios
> If the original cinfo is not used anymore, the use of its structure to
> handle the card information is not a good idea:
>
> - almost all cinfo information are in the struct snd_soc_card,
>
> - this cinfo structure cannot be extended to handle many DAI links,
>
> - it contains simple-card information which are of no use for the
> platform caller.
>
> So, I'd rather have seen:
>
> - the removal of 'snd_link' and 'snd_card' from the platform interface
> (struct asoc_simple_card_info),
>
> - the definition of a local struct simple_card_data containing the
> struct snd_soc_card and a pointer to an array of fmt/sysclk values
> (one per DAI link).
>
@Jean-Francios, apart from this separate issue we're discussing, do you have
any comment on this patch itself?
@Mark, Since what Jean-Francios is concerned by is another issue apart from
this patch itself and being discussed, can you apply the patch?
Thanks,
--
Best Regards,
Xiubo
N§²æìr¸yúèØb²X¬¶ÇvØ^)Þ{.nÇ+·¥{±êçzX§¶¡Ü}©²ÆzÚ&j:+v¨¾«êçzZ+Ê+zf£¢·h§~Ûiÿûàz¹®w¥¢¸?¨èÚ&¢)ßfù^jÇy§m
á@A«a¶Úÿ0¶ìh®åi