Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field ofgeneric_pm_domain

From: Mark Brown
Date: Sun Jan 12 2014 - 14:21:53 EST


On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote:

> static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
> - .name = "IROM",
> .ena = S3C64XX_NORMALCFG_IROM_ON,
> .pd = {
> + .name = "domain_irom",

This is nitpicking a bit but are you sure this is actually a
beautification of the name? It's mainly the domain_ bit, mostly since
I'd expect that if it's not obvious that this is a power domain the core
logging would be changed rather than tweaking the name of every power
domain user.

Attachment: signature.asc
Description: Digital signature