Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

From: Sagi Grimberg
Date: Sun Jan 12 2014 - 07:24:09 EST


On 1/10/2014 11:06 PM, Martin K. Petersen wrote:
"Sagi" == Sagi Grimberg <sagig@xxxxxxxxxxxx> writes:
Sagi> I wander how we can skip sbc_dif_verify_xxxx if the transport
Sagi> already offloaded DIF verify. I think that the transport should
Sagi> signal the core layer that it is able to offload DIF
Sagi> (ADD/STRIP/PASS/VERIFY), in which case the core should turn off
Sagi> the backstore DIF verify emulation to sustain performance.

Yeah, for SAS and FC it would be nice to leverage DIX and let the ASIC
do the actual checking and splitting. I assume the same is true for your
hw.


Correct! we should avoid a duplicate DIF processing. if the HW supports offloading DIF processing, target core can shutdown backstore verfy_read/verify_write methods.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/