Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include boundviolation information

From: Borislav Petkov
Date: Sun Jan 12 2014 - 04:30:33 EST

Next message: Bruce Liu: "Re: [PATCH 1/1] When timestamping is enabled, stmmac_tx_clean willcall stmmac_get_tx_hwtstamp to get tx TS. It's possible that skb is NULLbecause there are other network frames that use several descriptors. So wemust return immediately in stmmac_get_tx_hwtstamp if skb is NULL to avoidsystem crash."
Previous message: Hugh Dickins: "[PATCH] thp: fix copy_page_rep GPF by testing is_huge_zero_pmd onceonly"
In reply to: Qiaowei Ren: "[PATCH 5/5] x86, mpx: extend siginfo structure to include bound violation information"
Next in thread: H. Peter Anvin: "Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include boundviolation information"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Jan 12, 2014 at 05:20:03PM +0800, Qiaowei Ren wrote:
> This patch adds new fields about bound violation into siginfo
> structure. si_lower and si_upper are respectively lower bound
> and upper bound when bound violation is caused.
>
> These fields will be set in #BR exception handler by decoding
> the user instruction and constructing the faulting pointer.
> A userspace application can get violation address, lower bound
> and upper bound for bound violation from this new siginfo structure.
>
> Signed-off-by: Qiaowei Ren <qiaowei.ren@xxxxxxxxx>
> ---
> arch/x86/include/asm/mpx.h | 39 +++++
> arch/x86/kernel/mpx.c | 289 ++++++++++++++++++++++++++++++++++++

This thing looks like a partial duplication of functionality which we
already have - inat.*/insn.*, etc.

It would be cleaner to integrate the mpx pieces into the existing x86
insn analysis code and use it instead of growing your own, IMHO.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/