Re: [PATCH v2 7/28] drm/i2c: tda998x: set the video mode from theadjusted value

From: Russell King - ARM Linux
Date: Sat Jan 11 2014 - 12:11:42 EST


On Thu, Jan 09, 2014 at 11:59:03AM +0100, Jean-Francois Moine wrote:
> This patch uses always the adjusted video mode instead of a mix of
> original and adjusted mode.
>
> Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx>

No visible side effects here, but rather than copying the "adjusted_mode"
pointer to "mode", I'd much rather see the references to "mode" become
"adjusted_mode" instead - choose a shorter name if it's too long, maybe
"adj_mode" ?

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/