Re: [PATCH REPOST] ARM: Fix regression in IXP4xx network driversDMA masks.

From: Russell King - ARM Linux
Date: Sat Jan 11 2014 - 11:13:56 EST


On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof HaÅasa wrote:
> Russell et al.,
>
> anything wrong with this fix?

Well, I don't understand why moving this code around fixes a problem.
After all, if PCI is enabled, then presumably common-pci.c will always
be built and run - it has to be for the PCI bus to be probed.

Oh, are you trying to use the platform notify callback to set the
DMA mask on statically defined platform devices? No, don't do that,
initialise it in the declarations instead.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/