Re: [PATCH 2/3] mmc: Add realtek USB sdmmc host driver

[Oliver Neukum]

On Mon, 2013-12-23 at 17:52 +0800, rogerable@xxxxxxxxxxx wrote:
> From: Roger Tseng <rogerable@xxxxxxxxxxx>
> 
> Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
> USB card reader MFD driver.
> 
> Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx>

> +#ifdef DEBUG

Dynamic debugging would be nice.

> +static void sd_print_debug_regs(struct rtsx_usb_sdmmc *host)
> +{
> +	struct rtsx_ucr *ucr = host->ucr;
> +	u8 val = 0;
> +
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT1, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT1: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_STAT2, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_STAT2: 0x%x\n", val);
> +	rtsx_usb_ep0_read_register(ucr, SD_BUS_STAT, &val);
> +	dev_dbg(sdmmc_dev(host), "SD_BUS_STAT: 0x%x\n", val);
> +}
> +#else
> +#define sd_print_debug_regs(host)
> +#endif /* DEBUG */
> +


	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/