Re: [PATCH 0/2] ION dummy driver

From: John Stultz
Date: Thu Jan 09 2014 - 23:54:22 EST


On 01/09/2014 08:23 PM, Greg KH wrote:
> On Thu, Jan 09, 2014 at 07:40:53PM -0800, John Stultz wrote:
>> Greg: I realize this is after the usual -rc6 cutoff for staging,
>> so no pressure if you want to defer this for 3.15, but I saw you've
>> picked up a few things recently, so I figured I'd send it out so
>> I'm not just sitting on it while we wait for LCA to finish.
> I would have merged it, but I just tried and got a ton of errors when
> building:
>
> ERROR: "ion_device_destroy" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_heap_destroy" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_device_add_heap" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_heap_create" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
> ERROR: "ion_device_create" [drivers/staging/android/ion/ion_dummy_driver.ko] undefined!
>
> So, I'll just drop these patches and forget you ever sent them to me :)

Gah. Modules bite me every time! Should have been a bool and not
tristate in the Kconfig.

Sorry! I appreciate the heads up and the build related amnesia. :)

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/