[PATCH 2/3] perf: clarify comment regarding event merging

From: Cody P Schafer
Date: Thu Jan 09 2014 - 18:52:07 EST


There are actually 2 things about software events that allow us to
merge them: they never fail to schedule _and_ they have transaction
handlers we can (and do, when they are added to !sw groups) ignore. Note
both of these in the comment on adding sw events to !sw groups.

Signed-off-by: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx>
---
kernel/events/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index f574401..e9f60d0 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7065,7 +7065,8 @@ SYSCALL_DEFINE5(perf_event_open,
*
* Allow the addition of software events to !software
* groups, this is safe because software events never
- * fail to schedule.
+ * fail to schedule and have ignorable transaction
+ * handlers ({start,cancel,commit}_txn).
*/
pmu = group_leader->pmu;
} else if (is_software_event(group_leader) &&
--
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/