Re: [RFC][PATCH] tracing: Show available event triggers when notrigger is set

From: Steven Rostedt
Date: Thu Jan 09 2014 - 17:06:56 EST


On Wed, 08 Jan 2014 16:50:47 +0900
Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> [SNIP]
> > + if (v == SHOW_AVAILABLE_TRIGGERS) {
> > + seq_puts(m, "# Available triggers:\n");
> > + seq_putc(m, '#');
> > + mutex_lock(&trigger_cmd_mutex);
> > + list_for_each_entry(p, &trigger_commands, list)
>
> I guess the list_for_each_entry_reverse() will give a more intuitive
> result here:
>
> [root /sys/kernel/debug/tracing]# cat events/sched/sched_switch/trigger
> # Available triggers:
> # traceon traceoff snapshot stacktrace enable_event disable_event
>

Updated. Thanks for the review.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/