Re: [PATCH 1/7] ARM: perf_event: Silence sparse warning

From: Will Deacon
Date: Thu Jan 09 2014 - 05:46:03 EST


Hi Stephen,

On Wed, Jan 08, 2014 at 10:59:38PM +0000, Stephen Boyd wrote:
> arch/arm/kernel/perf_event_cpu.c:274:25: warning: incorrect type in assignment (different modifiers)
> arch/arm/kernel/perf_event_cpu.c:274:25: expected int ( *init_fn )( ... )
> arch/arm/kernel/perf_event_cpu.c:274:25: got void const *const data
>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---

Given that the rest of the series depends on the change to the percpu IRQ
stuff, I think you can just send this patch to Russell's patch system with
my ack:

Acked-by: Will Deacon <will.deacon@xxxxxxx>

Cheers,

Will

> arch/arm/kernel/perf_event_cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c
> index d85055cd24ba..20d553c9f5e2 100644
> --- a/arch/arm/kernel/perf_event_cpu.c
> +++ b/arch/arm/kernel/perf_event_cpu.c
> @@ -254,7 +254,7 @@ static int probe_current_pmu(struct arm_pmu *pmu)
> static int cpu_pmu_device_probe(struct platform_device *pdev)
> {
> const struct of_device_id *of_id;
> - int (*init_fn)(struct arm_pmu *);
> + const int (*init_fn)(struct arm_pmu *);
> struct device_node *node = pdev->dev.of_node;
> struct arm_pmu *pmu;
> int ret = -ENODEV;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/