Re: [PATCH 1/4] perf/x86/amd: AMD support for bp_len >HW_BREAKPOINT_LEN_8

[Frederic Weisbecker]

On Wed, Dec 11, 2013 at 06:28:23AM -0600, suravee.suthikulpanit@xxxxxxx wrote:
> @@ -295,11 +301,17 @@ static int arch_build_bp_info(struct perf_event *bp)
>  		break;
>  #endif
>  	default:
> -		return -EINVAL;
> +		if (!is_power_of_2(bp->attr.bp_len))
> +			return -EINVAL;
> +		if (!cpu_has_bpext)
> +			return -EOPNOTSUPP;
> +		info->mask = bp->attr.bp_len - 1;
> +		info->len = X86_BREAKPOINT_LEN_1;

I think I asked this before but I can't remember. So dr7 must have
length as LEN_1 for breakpoint extension?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/