Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748

[Chris Mason]

On Wed, 2014-01-08 at 13:01 -0800, Muthu Kumar wrote:
+AD4- On Wed, Jan 8, 2014 at 12:51 PM, Chris Mason +ADw-clm+AEA-fb.com+AD4- wrote:
+AD4- +AD4- On Wed, 2014-01-08 at 12:40 -0800, Muthu Kumar wrote:
+AD4- +AD4APg- On Wed, Jan 8, 2014 at 12:16 PM, Chris Mason +ADw-clm+AEA-fb.com+AD4- wrote:
+AD4- +AD4APg- +AD4- On Wed, 2014-01-08 at 11:54 -0800, Muthu Kumar wrote:
+AD4- +AD4APg- +AD4APg- Chris,
+AD4- +AD4APg- +AD4APg-
+AD4- +AD4APg- +AD4APg- +AFs-    8.336061+AF0- WARNING: CPU: 0 PID: 0 at fs/bio.c:1778 bio+AF8-endio+-0xbe/0x100()
+AD4- +AD4APg- +AD4APg- +AFs-    8.336062+AF0- bio+AF8-endio: bio for (unknown) without endio
+AD4- +AD4APg- +AD4APg-
+AD4- +AD4APg- +AD4APg- This is my recent change to avoid memory leak in bio+AF8-endio. But I
+AD4- +AD4APg- +AD4APg- think the problem is higher up, most likely bio+AF8-endio is called twice
+AD4- +AD4APg- +AD4APg- on the same bio (which was freed before).
+AD4- +AD4APg- +AD4APg-
+AD4- +AD4APg- +AD4-
+AD4- +AD4APg- +AD4- I think these are just two separate problems.  Lets ignore the WARN+AF8-ON
+AD4- +AD4APg- +AD4- for now.
+AD4- +AD4APg- +AD4-
+AD4- +AD4APg-
+AD4- +AD4APg- Not really... the BUG that is triggered:
+AD4- +AD4APg-
+AD4- +AD4APg- kernel BUG at fs/bio.c:523+ACE-
+AD4- +AD4APg-
+AD4- +AD4APg- It is in bio+AF8-put() (added to bio+AF8-endio() as part of recent change)
+AD4- +AD4APg- which gets an already freed bio.
+AD4- +AD4APg-
+AD4- +AD4-
+AD4- +AD4- Oh+ACE- I see.  Let me try with that one reverted.  Thanks+ACE-
+AD4- +AD4-
+AD4- +AD4- -chris
+AD4- +AD4-
+AD4- 
+AD4- But, like I said, problem is in different place. I am running a +ACI-dd+ACI-
+AD4- on ext4 fs for a while now, but didn't hit the problem. Any idea to
+AD4- repro locally? I would also suggest running just the for-3.1/core to
+AD4- isolate the issue.

Just reverting that change fixes it for me.  Jens mentioned it was
broken for on-stack bios.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/