Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

[Ian Abbott]

On 2014-01-08 08:35, Rostislav Lisovy wrote:
> Hello Dan;
>
> On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> > On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > > MF614 is not supported. More info about the cards may be found
> > > at http://humusoft.cz/produkty/datacq/
> > > The driver was tested with both cards. Everything seems to work
> > > properly. Just the basic functionality of the card (DIO, ADC, DAC)
> > > is supported by this driver.
> > >
> > > Signed-off-by: Rostislav Lisovy <lisovy@xxxxxxxxx>
> > >
> > >   create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
> >
> > There should be a "---" after the Signed-off-by line and before the
> > diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c"
> > line.  Otherwise, the diffstat gets included in the changelog.
> >
> > Signed-off-by: Rostislav Lisovy <lisovy@xxxxxxxxx>
> > ---
> > create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
>
> You are right, my mistake. But even though there should be v3 patch
> because I just realized there is an unnecessary comment in
> mf6x4_detach() and MF6X4_DAC_CHANN_CNT constant is no more used.
>
> Regards;
> Rostislav Lisovy

I'll wait for the v3 patch, but apart from that it looks fine to me.  I 
suppose it could be argued that the driver only uses 2 of the 3 BARs it 
ioremaps (a different 2 for each card), but they're only single page 
mappings.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/