Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

From: Arnd Bergmann
Date: Wed Jan 08 2014 - 05:09:17 EST


On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote:
> > +
> > +Example:
> > +
> > + reboot@0 {
> > + compatible = "apm,xgene-reboot";
> > + reg = <0x0 0x17000014 0x0 0x4>;
> > + };
>
> Given this seems to be a 64-bit address, the unit address should
> preferably be 0,17000014 rather than just 0.

I also wonder about the size and location of the register.
Are you sure the device is just a single 4-byte register at offset
0x14, rather than a complex device that happens to contain the
reset register?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/