Re: [PATCH] ASoC: generic: add generic compound card with DTsupport

[Jean-Francois Moine]

On Tue, 31 Dec 2013 11:59:27 +0000
Mark Brown <broonie@xxxxxxxxxx> wrote:

> > This code was first developped on the generic simple card, but its
> > recent DT extension cannot be easily extended again to support compound
> > cards as the one in the Cubox.  
> 
> It would have been useful to have provided that feedback at the time
> rather than waiting until after it had been merged - it was in review
> for long enough.  It would also be good to articulate the issues with
> the binding rather than simply stating they exist, and to consider
> adding a second binding to the existing generic card rather than adding
> a totally new card.

Sorry, I spent a lot of time on DPCM, and I was not yet ready to propose
something when you accepted Kuninori's patch.

> Please also remember that all DT patches need to be reviewed by the DT
> people, you've not CCed either them or the list.
> 
> > +  - front-end or back-end: present if the DAI link describes resp.
> > +		a front-end CPU DAI or a back-end CODEC DAI  
> 
> These are Linux-internal concepts which shouldn't appear in a DT binding
> or at the very least need definition.  One thing to consider here is
> that these things are all about the internals of a SoC and you'd
> therefore expect that they would be defined separately from the card so
> as to avoid having to replicate information in every card using a given
> SoC.

Do you mean that, as DPCM cannot be in the DT, there should be a
specific driver for the Cubox audio card (Marvell Armada 510 + NXP HDMI
transmitter)?

-- 
Ken ar c'hentaÃ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/