Re: [PATCH v2] Bluetooth: Add hci_h4p driver

From: Pali RohÃr
Date: Mon Dec 30 2013 - 09:04:18 EST


On Monday 30 December 2013 14:19:44 Sebastian Reichel wrote:
> Hi,
>
> On Mon, Dec 30, 2013 at 01:13:50PM +0100, Pavel Machek wrote:
> > [...]
> >
> > Well, I can rename config option, but renaming the module
> > would break existing userland, no?
>
> Why is the userland depending on the module name?
>

grep told me that hci_h4p is used only in these (text) files:

* /etc/modprobe.d/maemo.conf
alias platform:hci_h4p hci_h4p

So this is not needed if kernel driver contains correct
MODULE_ALIAS macro.

* /etc/event.d/bluetooth-sysinfo
echo ... > /sys/devices/platform/hci_h4p/bdaddr

This upstart script contains code for reading mac address from
special sysinfod daemon and setting it to kernel driver. Once
there will be uniform way for setting mac address that script can
be changed.

So I think that renaming module will not break anything if kernel
module will get (somehow) correct mac address (or if random one
is acceptable).

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.