[PATCH v2]vt: fix potential dual con_driver register for conswitchp

From: Wang YanQing
Date: Sun Dec 29 2013 - 22:22:46 EST


We should check whether conswitchp is registered before
add it to registered_con_driver in con_init, or it will
cause dual con_driver register for conswitchp.

Although I haven't met it in reality, but I think it could
happen for Embeded devices, who register platform con_driver
earlier than call con_init.

Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
---
Change v1-v2:
1: if conswitchp is registered, then
make it become "system driver" by
change value of first,last,flag.

drivers/tty/vt/vt.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 9adb4e0..b786129 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -2876,6 +2876,12 @@ static int __init con_init(void)
for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
struct con_driver *con_driver = &registered_con_driver[i];

+ if (con_driver->con == conswitchp) {
+ con_driver->flag = CON_DRIVER_FLAG_INIT;
+ con_driver->first = 0;
+ con_driver->last = MAX_NR_CONSOLES - 1;
+ break;
+ }
if (con_driver->con == NULL) {
con_driver->con = conswitchp;
con_driver->desc = display_desc;
--
1.8.3.4.8.g69490f3.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/