[PATCH 3.2 134/185] x86, efi: Don't use (U)EFI time services on32 bit

From: Ben Hutchings
Date: Sat Dec 28 2013 - 21:39:35 EST


3.2.54-rc1 review patch. If anyone has any objections, please let me know.

------------------

From: Matthew Garrett <matthew.garrett@xxxxxxxxxx>

commit 04bf9ba720fcc4fa313fa122b799ae0989b6cd50 upstream.

UEFI time services are often broken once we're in virtual mode. We were
already refusing to use them on 64-bit systems, but it turns out that
they're also broken on some 32-bit firmware, including the Dell Venue.
Disable them for now, we can revisit once we have the 1:1 mappings code
incorporated.

Signed-off-by: Matthew Garrett <matthew.garrett@xxxxxxxxxx>
Link: http://lkml.kernel.org/r/1385754283-2464-1-git-send-email-matthew.garrett@xxxxxxxxxx
Cc: Matt Fleming <matt.fleming@xxxxxxxxx>
Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
[bwh: Backported to 3.2: deleted code is slightly different]
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
arch/x86/platform/efi/efi.c | 7 -------
1 file changed, 7 deletions(-)

--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -614,11 +614,6 @@ void __init efi_init(void)

set_bit(EFI_MEMMAP, &x86_efi_facility);

-#ifdef CONFIG_X86_32
- x86_platform.get_wallclock = efi_get_time;
- x86_platform.set_wallclock = efi_set_rtc_mmss;
-#endif
-
#if EFI_DEBUG
print_efi_memmap();
#endif

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/