Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier

From: Geert Uytterhoeven
Date: Sat Dec 28 2013 - 14:25:49 EST


On Sat, Dec 28, 2013 at 8:25 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Is any of the "\x" (backslash + character) unused and thus available?
>
> I guess control characters would work.
>
> #define PRINTK_COMM "\001"

Not that one, cfr. include/linux/kern_levels.h ;-)

> #define PRINTK_PID "\002"
> #define PRINTK_TASK_ID "\003" /* "comm:pid" */
>
> printk(PRINTK_TASK_ID ": hair on fire\n");
>
> It's certainly compact. I doubt if there's any existing code which
> deliberately prints control chars?

But the rest looks OK to me.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/