Re: question about drivers/rtc/rtc-cmos.c

From: Julia Lawall
Date: Fri Dec 27 2013 - 15:26:46 EST


On Fri, 27 Dec 2013, Alessandro Zummo wrote:

> On Wed, 25 Dec 2013 20:32:12 +0100 (CET)
> Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
> > Is it intentional that the error code returned by
> > hpet_register_irq_handler is put ina local variable that will not be seen
> > at label cleanup1? The return value is retval, which is 0 at this point.
>
> Well, I'd say it's an error. Did you got it by hand
> or with one of your tools? ;)

Coccinelle. No idea if it an happen in real life.

I will drop err and replace it by retval.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/