Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path toabsolute path

From: David Ahern
Date: Fri Dec 27 2013 - 09:20:37 EST


On 12/27/13, 1:14 AM, Masami Hiramatsu wrote:
Nowhere, since there is no terminal code for user
command interface.

Those memories are released when the program terminated.
I think it is just a waste of the time to free the memory
pieces which are not used(and allocated) repeatedly.
Or, is there any chance to call this part directly from
other command?

Most of the functionality has a destructor to clean up memory allocations. probe code needs to follow suit.

e.g, from builtin-record.c:

err = __cmd_record(&record, argc, argv);

perf_evlist__munmap(evsel_list);
perf_evlist__close(evsel_list);
out_free_fd:
perf_evlist__delete_maps(evsel_list);
out_symbol_exit:
symbol__exit();

and __cmd_record ends by cleaning up the session struct.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/