Re: [PATCH] x86: Add check for number of available vectors beforeCPU down

[Prarit Bhargava]

On 12/03/2013 09:48 PM, rui wang wrote:
> On 11/20/13, Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
> Have you considered the case when an IRQ is destined to more than one CPU? e.g.:
> 
> bash# cat /proc/irq/89/smp_affinity_list
> 30,62
> bash#
> 
> In this case offlining CPU30 does not seem to require an empty vector
> slot. It seems that we only need to change the affinity mask of irq89.
> Your check_vectors() assumed that each irq on the offlining cpu
> requires a new vector slot.
> 

Rui,

The smp_affinity_list only indicates a preferred destination of the IRQ, not the
*actual* location of the CPU.  So the IRQ is on one of cpu 30 or 62 but not both
simultaneously.

If the case is that 62 is being brought down, then the smp_affinity mask will be
updated to reflect only cpu 30 (and vice versa).

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/