Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes onS3C24XX.

From: José Miguel Gonçalves
Date: Thu Dec 12 2013 - 20:57:06 EST


On 27-09-2013 15:17, Linus Walleij wrote:
On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
<jose.goncalves@xxxxxxx> wrote:

Some GPIO line limits are incorrectly set which, for instance,
does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.

Signed-off-by: José Miguel Gonçalves <jose.goncalves@xxxxxxx>
---
arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
OK but grrrr!

What needs to happen to the s3c24xx is to get rid of this file.

- Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
ARCH_NR_GPIO like everyone else

- Get rid of the config symbol NEED_MACH_GPIO_H

- Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
or whatever and make it local...

I will try to do this myself if noone else helps out, so I'd like to
carry this patch in the GPIO tree provided I can get an ACK from
the S3C24xx maintainer. Tomasz, is that you or Kukjin?

(BTW the above maybe goes for S3c64xx as well .. and S5P
oh well I will get to it.)


Was this patch forgotten?

José Gonçalves
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/