Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

[Borislav Petkov]

On Fri, Dec 06, 2013 at 11:11:07PM +0800, Ethan Zhao wrote:
> > @@ -63,10 +63,10 @@ TRACE_EVENT(aer_event,
> >
> >         TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
> >                 __get_str(dev_name),
> > -               __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" :
> > -                       __entry->severity == HW_EVENT_ERR_FATAL ?
> > +               __entry->severity == AER_CORRECTABLE ? "Corrected" :
> > +                       __entry->severity == AER_FATAL ?
> >                         "Fatal" : "Uncorrected",
> 
> Why not             "Fatal" : "Non-fatal",   ?  per the PCIe spec,
> 'Fatal' and 'Non-fatal' are sub-category of "
> Uncorrected". But here "Uncorrected" means "Non-fatal".

... and just to denote that, it'll probably be best to say:

		__entry->severity == AER_CORRECTABLE ? "Corrected" :
			__entry->severity == AER_FATAL ?
			   "Fatal" : "Uncorrected, non-fatal"

right?

Btw, Rui, you patch is whitespace-damaged so next time please try
sending from a real mail client which doesn't mangle whitespace and not
from the gmail web interface. Sending the patch to yourself and trying
to apply it is always a good test for that.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/