Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names givenin usb_bind_phy

From: Felipe Balbi
Date: Fri Dec 06 2013 - 16:09:45 EST


Hi,

On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez Canillas wrote:
> On Fri, Dec 6, 2013 at 1:06 PM, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
> > Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating
> > MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the
> > device name of the controller had *.auto* in it. Since with using
> > PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance,
> > the data given in usb_bind_phy became obsolete and usb_get_phy was failing.
> > So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding
> > change is done in board file here.
> >
> > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> > ---
> > arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> > arch/arm/mach-omap2/board-3430sdp.c | 2 +-
> > arch/arm/mach-omap2/board-cm-t35.c | 2 +-
> > arch/arm/mach-omap2/board-devkit8000.c | 2 +-
> > arch/arm/mach-omap2/board-ldp.c | 2 +-
> > arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
> > arch/arm/mach-omap2/board-omap3logic.c | 2 +-
> > arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
> > arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
> > arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
> > arch/arm/mach-omap2/board-overo.c | 2 +-
> > arch/arm/mach-omap2/board-rx51.c | 2 +-
> > 12 files changed, 12 insertions(+), 12 deletions(-)
> >
>
> You can drop this patch since boards files are being removed for v3.14

if we can drop this patch, the whole series is invalid, since we'll be
using DT phandles to find PHYs going forward, no ?

--
balbi

Attachment: signature.asc
Description: Digital signature