Re: [PATCH 2/3] ASoC: fsl: imx-wm8962: Grant hw_params/free()permission to control FLL

[Nicolin Chen]

On Fri, Dec 06, 2013 at 02:34:33PM +0000, Mark Brown wrote:
> On Fri, Dec 06, 2013 at 05:47:43PM +0800, Nicolin Chen wrote:
> 
> > +static int imx_wm8962_enable_fll(struct snd_soc_dai *codec_dai, u32 sample_rate,
> > +				snd_pcm_format_t sample_format)
> > +{
> > +	struct imx_priv *priv = &card_priv;
> > +	struct device *dev = &priv->pdev->dev;
> > +	struct imx_wm8962_data *data = platform_get_drvdata(priv->pdev);
> > +	u32 freq, ret;
> > +
> > +	if (data->fll_lock)
> > +		return 0;
> 
> Don't we need an actual lock to protect this?

Thank you for the advice, I will revise it.

Best regards,
Nicolin Chen


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/