Re: [PATCH v2 4/5] fat: fallback to buffered write in case offallocatded region on direct IO

[Namjae Jeon]

2013/12/1, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
>> index 12a37a9..c9fb9b6 100644
>> --- a/fs/fat/inode.c
>> +++ b/fs/fat/inode.c
>> @@ -217,6 +217,14 @@ static ssize_t fat_direct_IO(int rw, struct kiocb
>> *iocb,
>>  		loff_t size = offset + iov_iter_count(iter);
>>  		if (MSDOS_I(inode)->mmu_private < size)
>>  			return 0;
>> +
>> +		/*
>> +		 * In case of writing in fallocated region, return 0 and
>> +		 * fallback to buffered write.
>> +		 */
>> +		if (MSDOS_I(inode)->i_disksize >
>> +		    round_up(i_size_read(inode), inode->i_sb->s_blocksize))
>> +			return 0;
>
> ->mmu_private works instead of i_size?
Yes, I will change it.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/