Re: [PATCH v2 2/5] fat: add fat_fallocate operation

[Namjae Jeon]

2013/12/1, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>> +			err = fat_get_cluster(inode, FAT_ENT_EOF,
>> +					&fclus, &dclus);
>> +			if (err < 0) {
>> +				fat_msg(sb, KERN_ERR,
>> +					"fat_fallocate(): fat_get_cluster() error");
>> +				goto error;
>> +			}
>> +			free_bytes = ((fclus + 1) << sbi->cluster_bits) -
>> +				inode->i_size;
>
> What is wrong if we just used ->mmu_private here, instead of fclus?
It is not wrong. We can make it more simpler if we use mmu_private here.
I will change it.
Thanks for review.
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/