RE: [PATCH] crypto: remove unnecessary includes

From: Cristian Stoica
Date: Thu Dec 05 2013 - 04:11:02 EST


> If you can't work out why authenc.c needs slab.h I don't think
> you should be submitting patches removing unnecessary header
> files.

[]
You left out "kernel.h".

I really hoped this would not be your answer.

Yes, I'm an ignorant and yes, I ask questions. But if all you got is this type of answer, then maybe, just maybe, you should reconsider your ivory tower position.
The point is, if it's such a simple and obvious explanation, you should have said it instead of making me feel small. If it is not, then you should fix the pool of missing comments in crypto API (or should I read the obvious code instead?).
Even Linus pointed your mistakes when it was the case - or you never make mistakes?

You tried but your answer doesn't raise to the level of "kernel-locking.tmpl" one (and yes, I do get the "why" there).
For anyone else who cares, please lift me up from my ignorance.

Cristian S.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/