RE: [PATCH] crash_dump: fix compilation error (on MIPS at least)

[Qais Yousef]

> -----Original Message-----
> From: Vivek Goyal [mailto:vgoyal@xxxxxxxxxx]
> Sent: 04 December 2013 21:30
> To: Qais Yousef
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Andrew Morton; Michael Holzheu; linux-
> mips@xxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)
> 
> On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote:
> >   In file included from kernel/crash_dump.c:2:0:
> >   include/linux/crash_dump.h:22:27: error: unknown type name âpgprot_tâ
> >
> > when CONFIG_CRASH_DUMP=y
> >
> > The error was traced back to this commit:
> >
> >   9cb218131de1 vmcore: introduce remap_oldmem_pfn_range()
> >
> > include <asm/pgtable.h> to get the missing definition
> 
> pgprot_t definition for mips seems to be in asm/page.h. So why are you including
> asm/pgtable.h and not asm/page.h? For other architectures it seems to be in
> other files. That means those arch will have broken compilation now.

I didn't include asm/page.h because I didn't think it'll fix the problem for other arches.

> 
> So question is, is there any arch specific file which one can include and be covered
> for pgprot_t definition for all the arches.

I asked the same question and asm/pgtable.h was the answer.

Thanks,
Qais

> 
> Thanks
> Vivek
> 
> >
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Michael Holzheu <holzheu@xxxxxxxxxxxxxxxxxx>
> > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
> > Cc: <linux-mips@xxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.12
> > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
> > Signed-off-by: Qais Yousef <qais.yousef@xxxxxxxxxx>
> > ---
> > I haven't tried any other architecture except mips.
> > If OK this should be considered for stable 3.12 (CCed).
> >
> >  include/linux/crash_dump.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> > index fe68a5a..7032518 100644
> > --- a/include/linux/crash_dump.h
> > +++ b/include/linux/crash_dump.h
> > @@ -6,6 +6,8 @@
> >  #include <linux/proc_fs.h>
> >  #include <linux/elf.h>
> >
> > +#include <asm/pgtable.h> /* for pgprot_t */
> > +
> >  #define ELFCORE_ADDR_MAX	(-1ULL)
> >  #define ELFCORE_ADDR_ERR	(-2ULL)
> >
> > --
> > 1.7.1
> >
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—