Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

From: Arnaldo Carvalho de Melo
Date: Wed Dec 04 2013 - 13:53:17 EST


Em Wed, Dec 04, 2013 at 03:50:24PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu:
> > Adding udis86 disassembler feature check which support
> > is needed for kvm:kvm_emulate_insn tracepoint.

> > +$(call feature_check,udis86)
> > +ifeq ($(feature-udis86), 1)
> > + LIBTRACEEVENT_CFLAGS += -DHAVE_UDIS86
> > + EXTLIBS += -ludis86
> > +else
> > + msg := $(warning No udis86 support.);
> > +endif

> That is really an incomplete message, what package should I install?
> Perhaps we should add this there then:

> http://bit.ly/1hyrN52

> Wow, that was easy, but yeah, could be made easier 8-) ;-P

Jokes aside, I'm dropping this one for now, as it breaks feature
detection, now everytime I run make I get:

Auto-detecting system features:
... backtrace: [ on ]
... dwarf: [ on ]
... fortify-source: [ on ]
... glibc: [ on ]
... gtk2: [ on ]
... gtk2-infobar: [ on ]
... libaudit: [ on ]
... libbfd: [ on ]
... libelf: [ on ]
... libelf-getphdrnum: [ on ]
... libelf-mmap: [ on ]
... libnuma: [ on ]
... libperl: [ on ]
... libpython: [ on ]
... libpython-version: [ on ]
... libslang: [ on ]
... libunwind: [ on ]
... on-exit: [ on ]
... stackprotector-all: [ on ]
... timerfd: [ on ]

config/Makefile:421: No udis86 support.

---

Please try to fix it and resubmit. And yes, I don't have udis86-devel
installed in this test system.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/