Re: [PATCH 1/3] clk: bcm281xx: define kona clock binding

[Alex Elder]

On 12/04/2013 06:45 AM, Alex Elder wrote:
>>> +Device tree example:
>>> >> +
>>> >> +	clocks {
>>> >> +		slave_ccu: slave_ccu {
>>> >> +			compatible = "brcm,bcm11351-slave-ccu";
>>> >> +			reg = <0x3e011000 0x0f00>;
>>> >> +			#clock-cells = <1>;
>>> >> +			clock-output-names = "uartb",
>>> >> +					     "uartb2",
>>> >> +					     "uartb3",
>>> >> +					     "uartb4";
>>> >> +		};
>>> >> +		ref_crystal_clk: ref_crystal {
>>> >> +			#clock-cells = <0>;
>>> >> +			compatible = "fixed-clock";
>>> >> +			clock-frequency = <26000000>;
>>> >> +		};
>>> >> +	};
>> > 
>> > This is wrong, as the clocks container node us not defined as any type
>> > of bus, and does not have the requisite #address-cells and #size-cells.
> Sorry, I didn't realize it was wrong.  I intentionally used
> it simply for groiuping.

I should have looked at my actual dtsi file before responding.

It turns out that what was shown there was not complete.  The
dtsi file in fact does contain #address-cells and #size-cells
(and a direct-mapping "ranges" property).

I have removed the enclosing "clocks" node and its braces in
the document.  I have not removed the node from the dtsi file.

					-Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/