Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk forgen2 platforms

From: Ingo Molnar
Date: Wed Dec 04 2013 - 10:15:59 EST



* Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:

> On Wed, Dec 04, 2013 at 10:08:14AM +0100, Ingo Molnar wrote:
> >
> > * ville.syrjala@xxxxxxxxxxxxxxx <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> >
> > > v2: Rewrite to use the TOM-TSEG_SIZE-stolen_size and TOUD methods
> >
> > I guess v2 is a reaction to my review feedback? I got no reply to my
> > mail from you so I'm not sure and I'd like to know whether all
> > feedback was addressed.
>
> Actually this was mostly insipired by a private mail from hpa. I forgot
> to reply to your mail, sorry about that.
>
> But anyways, I think apart from your comment about the KB/MB macros,
> the rest of the comments no longer apply. [...]

Ok.

> [...] And as far as those macros go, there seem to be similar macros
> already sprinkled around in various places, so I'm not sure how big
> of a fallout we'd have if I just stick them into kernel.h.

That was a separate suggestion, outside the scope of this series.

Anyway, this v2 series looks good.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/