Re: [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCIdriver for the Allwinner SUNXi series of SoCs

[Oliver Schinagl]

On 04-12-13 13:26, Mark Rutland wrote:
> On Wed, Dec 04, 2013 at 12:10:54PM +0000, oliver@xxxxxxxxxxx wrote:
> > From: Oliver Schinagl <oliver@xxxxxxxxxxx>
> >
> > This patch adds support for the sunxi series of SoC's by allwinner. It
> > plugs into the ahci-platform framework.
> >
> > Note: Currently it uses a somewhat hackish approach that probably needs
> > a lot more work, but does the same as the IMX SoC's.
> >
> > Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/ata/ahci-sunxi.txt         |  24 ++
> >   drivers/ata/Kconfig                                |   9 +
> >   drivers/ata/Makefile                               |   1 +
> >   drivers/ata/ahci_platform.c                        |  12 +
> >   drivers/ata/ahci_sunxi.c                           | 305 +++++++++++++++++++++
> >   5 files changed, 351 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/ata/ahci-sunxi.txt
> >   create mode 100644 drivers/ata/ahci_sunxi.c
> >
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-sunxi.txt b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt
> > new file mode 100644
> > index 0000000..0792fa5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ahci-sunxi.txt
> > @@ -0,0 +1,24 @@
> > +Allwinner SUNXI AHCI SATA Controller
> > +
> > +SATA nodes are defined to describe on-chip Serial ATA controllers.
> > +Each SATA controller should have its own node.
> > +
> > +Required properties:
> > +- compatible   : compatible list, contains "allwinner,sun4i-a10-ahci"
> - compatible: Should contain "allwinner,sun4i-a10-ahci"
>
> > +- reg          : <registers mapping>
> - reg: The offset and length of the MMIO registers.
>
> > +- interrupts   : <interrupt mapping for AHCI IRQ>
> - interrupts: An interrupt-specifier for the ACHI interrupt
>
> > +- clocks       : clocks for ACHI
> > +- clock-names  : clock names for AHCI
> Please _define_ the set of clock-names you expect. This binding is
> meaningless without it. If you require clock-names, define the clocks
> property in terms of it.
I copied ahci_platform.txt and filled in the missing bits, I will 
improve all the above. Appologies!
> Thanks,
> Mark.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/