Re: [PATCH -tip v4 0/6] kprobes: introduce NOKPROBE_SYMBOL() andfixes crash bugs

From: Ingo Molnar
Date: Wed Dec 04 2013 - 03:46:06 EST



* Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:

> Hi,
> Here is the version 4 of NOKPORBE_SYMBOL series.
>
> In this version, I removed the cleanup patches and
> add bugfixes I've found, since those bugs will be
> critical.
>
> Rest of the cleanup and visible blacklists will be proposed later in
> another series.

Ok, let me make it clear: we need _both_ the conceptual cleanups and
the bug fixes.

Right now kprobes are restricted to root, and they are unsafe and
buggy, and rather fundamentally so, because probing cannot be done
safely without potentially crashing the kernel. So there's no
'regression' to be fixed, it's mostly about pre-existing bugs - so
there's no requirement for them to come before maintainability
cleanups.

So we need both a maintainable and a sane/safe solution, and I'd like
to apply the whole thing at once and be at ease that the solution is
round. We should have done this years ago.

So could you please send a whole series that I can apply to -tip as a
work in progress tree, and then we can see what is left to be solved?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/