Re: [PATCH] Staging: speakup: synth.c: removed a space

From: Dan Carpenter
Date: Wed Dec 04 2013 - 02:39:45 EST


On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
> Samuel Thibault wrote:
>
> > Err, I'd rather make it really visible that the for loop doesn't have
> > its first statement?
>
> Wouldn't it be better if you add a comment there? So it would follow the
> coding style?

No. Adding obvious comments is more annoying than the space.

This seems like a small bug in checkpatch.pl. Joe, the problem is this
code:

for ( ; x; x++) {

It's complaining about the space character before the semicolon.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/