Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

From: Greg Kroah-Hartman
Date: Wed Dec 04 2013 - 02:03:43 EST


On Tue, Dec 03, 2013 at 11:39:21PM -0500, Adrien Vergé wrote:
> Usage of ETM tracing facility is currently very limited: user can
> only start/stop tracing. This set of patches enables management of
> address combinations and PIDs that trigger tracing.
>
> ETM management was done via sysfs entries (trace_info,
> trace_running...), this code adds trace_addrrange and trace_pid to
> let the user read/write custom values.

I have lots to say about this from a sysfs point of view, but first, why
is it in sysfs at all? Shouldn't all of this be in debugfs?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/