Re: [PATCHv2 1/2] New Driver for IOSF-SB MBI access on Intel SOCs

From: Andi Kleen
Date: Wed Dec 04 2013 - 01:44:27 EST


"David E. Box" <david.e.box@xxxxxxxxxxxxxxx> writes:
>
> +config X86_IOSF_MBI
> + tristate "IOSF-SB MailBox Interface access support for Intel
> SOCs"

This is only implicitly used by other drivers, right?

Please make it not user visible (drop the string after tristate), as users
will not know when to enable it.

The other drivers using it should always select it instead.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/